Styjun

I reverse the source code, you negate the output!

Would Taiwan and China's dispute be solved if Taiwan gave up being the Republic of China?

Leaving a job that I just took based on false promise of a raise. What do I tell future interviewers?

Did Apollo carry and use WD40?

Do the villains know Batman has no superpowers?

An Algorithm Which Schedules Your Life

How to manage expenditure when billing cycles and paycheck cycles are not aligned?

How much Damage can be done with "just" heating matter?

Writing a letter of recommendation for a mediocre student

Examples of "unsuccessful" theories with afterlives

What happens if nobody can form a government in Israel?

Where are they calling from?

Will Proving or Disproving of any of the following have effects on Chemistry in general?

Is it impolite to ask for halal food when traveling to and in Thailand?

What benefits does the Power Word Kill spell have?

What was the deeper meaning of Hermione wanting the cloak?

Safely hang a mirror that does not have hooks

Resolving moral conflict

Do you need to hold concentration on a spell when you cast it with a spell scroll?

Is it more effective to add yeast before or after kneading?

Allocating credit card points

How can I repair this gas leak on my new range? Teflon tape isn't working

Is it true that, "just ten trading days represent 63 per cent of the returns of the past 50 years"?

What is this utensil for?

Pagination with Spring-Data : PageRequest leaking into REST Controller

Best Practices for securing a REST API / web serviceRESTful AuthenticationPagination in a REST web applicationREST HTTP status codes for failed validation or invalid duplicatePosting a File and Associated Data to a RESTful WebService preferably as JSONHow to solve “Plugin execution not covered by lifecycle configuration” for Spring Data Maven BuildsHow do I POST JSON data with Curl from a terminal/commandline to Test Spring REST?What is difference between CrudRepository and JpaRepository interfaces in Spring Data JPA?REST API response describing request and returned dataHow to prevent shifting of paged data in a REST API result set

.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;

0

1

I'm working on a REST API based on Spring-Boot with a MongoDB database. The application uses a Controller > Service > Repository approach. I'm currently working on implementing a paginated endpoint:

/api/clients?range=offset-limit

eg. /api/clients?range=0-25 (retrieves entities 0-24)

My problem is that, in order to build a 'Content Range' response and in order to distinguish between 200 'OK' and 206 'Partial Content' responses (depending on whether the request retrieves all the entities or not), I need to retrieve info like the total number of entities from a Page object. So I'm building a PageRequest in the Controller which gets passed to the Service and through to the Repository. I end up with something along these lines :

@ResponseBody
@GetMapping(params = "range" )
public ResponseEntity<?> getAllClients(
 final @RequestParam(value = "range", required = false) QueryRange queryRange,
 final HttpServletResponse response) 

 response.addHeader(HttpHeaders.ACCEPT_RANGES, "client " + MAX_CLIENTS);

 if (queryRange.getCount() > MAX_CLIENTS) 
 throw new ForbiddenRangeException("client", MAX_CLIENTS);
 

 Integer offset = queryRange.getOffset();
 Integer limit = queryRange.getLimit();

 Integer count = limit - offset;
 Integer page = offset != 0 ? offset / count : 0;

 PageRequest request = PageRequest.of(page, count);

 final Page<Client> clients = clientService.getAllClients(request);

 final HttpStatus status = (queryRange.getOffset() == 0 && clients.isLast())
 ? HttpStatus.OK
 : HttpStatus.PARTIAL_CONTENT;

 final String contentRange = String.format("%d-%d/%d",
 queryRange.getOffset(),
 queryRange.getOffset() + clients.getContent().size() - 1,
 clients.getTotalElements());

 response.addHeader(HttpHeaders.CONTENT_RANGE, contentRange);

 return new ResponseEntity<>(clients, status);

How could one structure this in order to prevent such leaking ?

Any ideas?

mongodb rest spring-boot spring-data

share|improve this question

edited Mar 29 at 9:49

Anthony Webster

asked Mar 28 at 15:38

Anthony WebsterAnthony Webster

7933 silver badges1111 bronze badges

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  What is the question?
  
  – Oliver Drotbohm
  Mar 29 at 6:38
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  I've amended the original question. Basically, in this use case is there a way to avoid spring-data concepts such as Pageable from leaking all the way up to the controller ?
  
  – Anthony Webster
  Mar 29 at 10:55
  

  
  
  
  

add a comment
 | 

0

1

I'm working on a REST API based on Spring-Boot with a MongoDB database. The application uses a Controller > Service > Repository approach. I'm currently working on implementing a paginated endpoint:

/api/clients?range=offset-limit

eg. /api/clients?range=0-25 (retrieves entities 0-24)

My problem is that, in order to build a 'Content Range' response and in order to distinguish between 200 'OK' and 206 'Partial Content' responses (depending on whether the request retrieves all the entities or not), I need to retrieve info like the total number of entities from a Page object. So I'm building a PageRequest in the Controller which gets passed to the Service and through to the Repository. I end up with something along these lines :

@ResponseBody
@GetMapping(params = "range" )
public ResponseEntity<?> getAllClients(
 final @RequestParam(value = "range", required = false) QueryRange queryRange,
 final HttpServletResponse response) 

 response.addHeader(HttpHeaders.ACCEPT_RANGES, "client " + MAX_CLIENTS);

 if (queryRange.getCount() > MAX_CLIENTS) 
 throw new ForbiddenRangeException("client", MAX_CLIENTS);
 

 Integer offset = queryRange.getOffset();
 Integer limit = queryRange.getLimit();

 Integer count = limit - offset;
 Integer page = offset != 0 ? offset / count : 0;

 PageRequest request = PageRequest.of(page, count);

 final Page<Client> clients = clientService.getAllClients(request);

 final HttpStatus status = (queryRange.getOffset() == 0 && clients.isLast())
 ? HttpStatus.OK
 : HttpStatus.PARTIAL_CONTENT;

 final String contentRange = String.format("%d-%d/%d",
 queryRange.getOffset(),
 queryRange.getOffset() + clients.getContent().size() - 1,
 clients.getTotalElements());

 response.addHeader(HttpHeaders.CONTENT_RANGE, contentRange);

 return new ResponseEntity<>(clients, status);

How could one structure this in order to prevent such leaking ?

Any ideas?

mongodb rest spring-boot spring-data

share|improve this question

edited Mar 29 at 9:49

Anthony Webster

asked Mar 28 at 15:38

Anthony WebsterAnthony Webster

7933 silver badges1111 bronze badges

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  What is the question?
  
  – Oliver Drotbohm
  Mar 29 at 6:38
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  I've amended the original question. Basically, in this use case is there a way to avoid spring-data concepts such as Pageable from leaking all the way up to the controller ?
  
  – Anthony Webster
  Mar 29 at 10:55
  

  
  
  
  

add a comment
 | 

I'm working on a REST API based on Spring-Boot with a MongoDB database. The application uses a Controller > Service > Repository approach. I'm currently working on implementing a paginated endpoint:

/api/clients?range=offset-limit

eg. /api/clients?range=0-25 (retrieves entities 0-24)

My problem is that, in order to build a 'Content Range' response and in order to distinguish between 200 'OK' and 206 'Partial Content' responses (depending on whether the request retrieves all the entities or not), I need to retrieve info like the total number of entities from a Page object. So I'm building a PageRequest in the Controller which gets passed to the Service and through to the Repository. I end up with something along these lines :

@ResponseBody
@GetMapping(params = "range" )
public ResponseEntity<?> getAllClients(
 final @RequestParam(value = "range", required = false) QueryRange queryRange,
 final HttpServletResponse response) 

 response.addHeader(HttpHeaders.ACCEPT_RANGES, "client " + MAX_CLIENTS);

 if (queryRange.getCount() > MAX_CLIENTS) 
 throw new ForbiddenRangeException("client", MAX_CLIENTS);
 

 Integer offset = queryRange.getOffset();
 Integer limit = queryRange.getLimit();

 Integer count = limit - offset;
 Integer page = offset != 0 ? offset / count : 0;

 PageRequest request = PageRequest.of(page, count);

 final Page<Client> clients = clientService.getAllClients(request);

 final HttpStatus status = (queryRange.getOffset() == 0 && clients.isLast())
 ? HttpStatus.OK
 : HttpStatus.PARTIAL_CONTENT;

 final String contentRange = String.format("%d-%d/%d",
 queryRange.getOffset(),
 queryRange.getOffset() + clients.getContent().size() - 1,
 clients.getTotalElements());

 response.addHeader(HttpHeaders.CONTENT_RANGE, contentRange);

 return new ResponseEntity<>(clients, status);

How could one structure this in order to prevent such leaking ?

Any ideas?

mongodb rest spring-boot spring-data

share|improve this question

edited Mar 29 at 9:49

Anthony Webster

asked Mar 28 at 15:38

Anthony WebsterAnthony Webster

7933 silver badges1111 bronze badges

/api/clients?range=offset-limit

eg. /api/clients?range=0-25 (retrieves entities 0-24)

@ResponseBody
@GetMapping(params = "range" )
public ResponseEntity<?> getAllClients(
 final @RequestParam(value = "range", required = false) QueryRange queryRange,
 final HttpServletResponse response) 

 response.addHeader(HttpHeaders.ACCEPT_RANGES, "client " + MAX_CLIENTS);

 if (queryRange.getCount() > MAX_CLIENTS) 
 throw new ForbiddenRangeException("client", MAX_CLIENTS);
 

 Integer offset = queryRange.getOffset();
 Integer limit = queryRange.getLimit();

 Integer count = limit - offset;
 Integer page = offset != 0 ? offset / count : 0;

 PageRequest request = PageRequest.of(page, count);

 final Page<Client> clients = clientService.getAllClients(request);

 final HttpStatus status = (queryRange.getOffset() == 0 && clients.isLast())
 ? HttpStatus.OK
 : HttpStatus.PARTIAL_CONTENT;

 final String contentRange = String.format("%d-%d/%d",
 queryRange.getOffset(),
 queryRange.getOffset() + clients.getContent().size() - 1,
 clients.getTotalElements());

 response.addHeader(HttpHeaders.CONTENT_RANGE, contentRange);

 return new ResponseEntity<>(clients, status);

share|improve this question

edited Mar 29 at 9:49

Anthony Webster

asked Mar 28 at 15:38

Anthony WebsterAnthony Webster

7933 silver badges1111 bronze badges

share|improve this question

edited Mar 29 at 9:49

Anthony Webster

asked Mar 28 at 15:38

Anthony WebsterAnthony Webster

7933 silver badges1111 bronze badges

asked Mar 28 at 15:38

Anthony WebsterAnthony Webster

7933 silver badges1111 bronze badges

asked Mar 28 at 15:38

Anthony WebsterAnthony Webster

7933 silver badges1111 bronze badges