Styjun

Can criminal fraud exist without damages?

Where in the Bible does the greeting ("Dominus Vobiscum") used at Mass come from?

Everything Bob says is false. How does he get people to trust him?

What to do with wrong results in talks?

If you attempt to grapple an opponent that you are hidden from, do they roll at disadvantage?

The plural of 'stomach"

What is the intuitive meaning of having a linear relationship between the logs of two variables?

Can somebody explain Brexit in a few child-proof sentences?

What is the oldest known work of fiction?

Understanding "audieritis" in Psalm 94

is this a spam?

Confused about a passage in Harry Potter y la piedra filosofal

Modify casing of marked letters

The baby cries all morning

Can I use my Chinese passport to enter China after I acquired another citizenship?

Do there exist finite commutative rings with identity that are not Bézout rings?

How do I keep an essay about "feeling flat" from feeling flat?

There is only s̶i̶x̶t̶y one place he can be

voltage of sounds of mp3files

How was Earth single-handedly capable of creating 3 of the 4 gods of chaos?

Efficiently merge handle parallel feature branches in SFDX

What would happen if the UK refused to take part in EU Parliamentary elections?

Is a roofing delivery truck likely to crack my driveway slab?

What would be the benefits of having both a state and local currencies?

Is it bad practice to pass a components scope to a store service - Angular

Angular - Use pipes in services and componentsAngular 2 Sibling Component CommunicationAngular2 is this the right way to use Observables?Angular 2 duplicated subscription in componentAngular: Subscribing and Observing in ServicesGet unique/latest value from observable in component class (result of store selector)Angular RxJS - Unsubscribe from mergeMap?Angular 6 http service best practiceWhen Components or Services in Angular 2 get destroyed?Destroy Angular 5 components when move to another menu

0

Currently this is how I'm subscribing to relevant parts of my state in components:

 this.store.pipe(
 select((state: any) => state.data.relevantInfo),
 untilDestroyed(this))
 .subscribe((relevantInfo: RelevantInfo) => 
 this.doSomethingWithInfo(relevantInfo));

untilDestoryed(this) is an npm package which automatically unsubscribes when the component is destroyed.

Since I subscribe to the same parts of the state in different components, I was thinking about creating a Store Service, which returns the corresponding observable...

 selectRelevantInfo(scope) 
 return this.store.pipe(select((state: State) => state.data.relevantInfo),
 untilDestroyed(scope));
 

...and calling it like this:

this.storeService.selectRelevantInfo(this)
 .subscribe((relevantInfo: RelevantInfo) => 
 this.doSomethingWithInfo(relevantInfo));

Now my question is, would passing the scope this to the StoreService be considered bad practice? Because it probably is - any idea how I could clean up the subscriptions without following this approach? Thanks!

angular redux ngrx

share|improve this question

asked Mar 21 at 15:26

LiquidLiquid

397

• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  Why not just this.storeService.selectRelevantInfo().pipe(untilDestroyed(this).... instead of doing it in the service. Your services shouldn't be the one handling unsubscribe.
  
  – penleychan
  Mar 21 at 15:50
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Ah of course, that makes sense. Thanks a lot for your suggestion!
  
  – Liquid
  Mar 21 at 15:53
  

  
  
  
  

add a comment | 

0

Currently this is how I'm subscribing to relevant parts of my state in components:

 this.store.pipe(
 select((state: any) => state.data.relevantInfo),
 untilDestroyed(this))
 .subscribe((relevantInfo: RelevantInfo) => 
 this.doSomethingWithInfo(relevantInfo));

untilDestoryed(this) is an npm package which automatically unsubscribes when the component is destroyed.

Since I subscribe to the same parts of the state in different components, I was thinking about creating a Store Service, which returns the corresponding observable...

 selectRelevantInfo(scope) 
 return this.store.pipe(select((state: State) => state.data.relevantInfo),
 untilDestroyed(scope));
 

...and calling it like this:

this.storeService.selectRelevantInfo(this)
 .subscribe((relevantInfo: RelevantInfo) => 
 this.doSomethingWithInfo(relevantInfo));

Now my question is, would passing the scope this to the StoreService be considered bad practice? Because it probably is - any idea how I could clean up the subscriptions without following this approach? Thanks!

angular redux ngrx

share|improve this question

asked Mar 21 at 15:26

LiquidLiquid

397

• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  Why not just this.storeService.selectRelevantInfo().pipe(untilDestroyed(this).... instead of doing it in the service. Your services shouldn't be the one handling unsubscribe.
  
  – penleychan
  Mar 21 at 15:50
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Ah of course, that makes sense. Thanks a lot for your suggestion!
  
  – Liquid
  Mar 21 at 15:53
  

  
  
  
  

add a comment | 

Currently this is how I'm subscribing to relevant parts of my state in components:

 this.store.pipe(
 select((state: any) => state.data.relevantInfo),
 untilDestroyed(this))
 .subscribe((relevantInfo: RelevantInfo) => 
 this.doSomethingWithInfo(relevantInfo));

untilDestoryed(this) is an npm package which automatically unsubscribes when the component is destroyed.

Since I subscribe to the same parts of the state in different components, I was thinking about creating a Store Service, which returns the corresponding observable...

 selectRelevantInfo(scope) 
 return this.store.pipe(select((state: State) => state.data.relevantInfo),
 untilDestroyed(scope));
 

...and calling it like this:

this.storeService.selectRelevantInfo(this)
 .subscribe((relevantInfo: RelevantInfo) => 
 this.doSomethingWithInfo(relevantInfo));

Now my question is, would passing the scope this to the StoreService be considered bad practice? Because it probably is - any idea how I could clean up the subscriptions without following this approach? Thanks!

angular redux ngrx

share|improve this question

asked Mar 21 at 15:26

LiquidLiquid

397

 this.store.pipe(
 select((state: any) => state.data.relevantInfo),
 untilDestroyed(this))
 .subscribe((relevantInfo: RelevantInfo) => 
 this.doSomethingWithInfo(relevantInfo));

 selectRelevantInfo(scope) 
 return this.store.pipe(select((state: State) => state.data.relevantInfo),
 untilDestroyed(scope));
 

this.storeService.selectRelevantInfo(this)
 .subscribe((relevantInfo: RelevantInfo) => 
 this.doSomethingWithInfo(relevantInfo));

angular redux ngrx

angular redux ngrx

share|improve this question

asked Mar 21 at 15:26

LiquidLiquid

397

share|improve this question

asked Mar 21 at 15:26

LiquidLiquid

397

asked Mar 21 at 15:26

LiquidLiquid

397

asked Mar 21 at 15:26

LiquidLiquid

397