Styjun

I'm trying to rework an existing C# Winforms tool.
The idea is to use Powershell for specific commands to computers.

I have a BindingList which will be filled with ADComputer objects on button click, these machines will be pinged asynchronously. When each individual machine returns his ping, the code would previously fire a WMI query using a ManagementOperationObserver. On ObjectReady it would return the logged in username.

For performance and maintenance reasons I would like to use Powershell for the WMI part of the code.

I was thinking about the Powershell automation class, but I would need an event for when the script is done to report back to the GUI. As it would be an async operation, the code shouldn't block other machines from executing code as well. I don't know if this is the best option though.

This is the code setup:

private BindingList<ADComputer> ADComputers = new BindingList<ADComputer>();

private void SearchADButton_Click(object sender, EventArgs e) 
 ADComputers.Clear();

 //Code to fill ADComputers...

 for (int i = 0; i < ADComputers.Count; i++) 
 int index = i;
 Ping ping = new Ping();
 ping.PingCompleted += (sender2, e2) => Ping_PingCompleted(sender2, e2, index);
 ping.SendPingAsync(ADComputers[i].Name);
 
 

private void Ping_PingCompleted(object sender, PingCompletedEventArgs e, int index) 
 if(e.Error == null && e.Reply.Status.Equals(IPStatus.Success)) 
 ADComputers[index].Online = "Online";
 PClist.InvalidateRow(index);

 //Powershell goes here!!!
 
 else 
 ADComputers[index].Online = "Offline";
 ADComputers[index].LoggedIn = "/";
 PClist.InvalidateRow(index);
 
 

Can anyone explain and/or give an example of the best practices doing this?