Styjun

How many people are necessary to maintain modern civilisation?

How does DC work with natural 20?

What is the origin of Scooby-Doo's name?

Boss wants someone else to lead a project based on the idea I presented to him

What happened to Steve's Shield in Iron Man 2?

How do I farm creepers for XP without them exploding?

Android Material and appcompat Manifest merger failed in react-native or ExpoKit

RandomInteger with equal number of 1 and -1

Should an enameled cast iron pan be seasoned?

What is the meaning of "понаехать"?

Can humans ever directly see a few photons at a time? Can a human see a single photon?

How to remove this component from PCB

How to make clear to people I don't want to answer their "Where are you from?" question?

Why does independence imply zero correlation?

Shooting someone's past self using special relativity

Data analysis internship not going well because of lack of programming background

Prime sieve in Python

Why does cooking oatmeal starting with cold milk make it creamy?

How would modern naval warfare have to have developed differently for battleships to still be relevant in the 21st century?

Helping ease my back pain by studying 13 hours everyday , even weekends

What is upper left vol?

Why don't countries like Japan just print more money?

Confusion over 220 and 230 volt outlets

When to remove insignificant variables?

Proper way to update (update fallback) a list of entities with child entities?

What is the proper way to re-throw an exception in C#?How to Stop Auto Generate columns in FlexgridFastest Way of Inserting in Entity FrameworkLINQ to Entity Framework many to many with list of stringsEntity Framework 5 Updating a RecordProper way to initialize a C# dictionary with values?Inner query(sub query) using LINQ to Entities that returns IEnumerable Lists within ListsASP Core MVC Scaffolding SelectList (RC1) not populating dataEntity FrameWork How to update list recordEF issue adding entity with list of child entities

.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty height:90px;width:728px;box-sizing:border-box;

0

I'm building a .net core 2 api with EF core .
the api gets a list (3K-5K) of entities(DTOs) to sync using a general syncItems function.

assume the following entities :

 public class supplier

 [Key]
 public string supplierCode get; set; 

 public string name get; set; 


 public class item 

 public const int maxItemName = 256;
 public const int maxItemCode = 256;
 public const int maxBarcode = 256;
 [Required]
 [StringLength(maxItemName)]
 public string itemName get; set; 

 [Required]
 [StringLength(maxItemCode)]
 [Key]
 public string sku get; set; 

 public supplier supplier get; set; 


 public ICollection<itemWarehouse> whslines = new List<itemWarehouse>();

 public item()
 

 



my sync does the following : 

var itemsInApp=_appDbContext.items.ToList();
 // insert or update items.
 items.ForEach(erpitem =>
 
 bool newflag = false;
 item tempItem = itemsInApp.Where(x => x.sku == erpitem.sku).FirstOrDefault();
 if (tempItem==null) // check if item is null
 
 tempItem = new item();
 tempItem.sku = erpitem.sku;
 newflag = true;
 
 tempItem.itemName = erpitem.itemName;
 var sup = _appDbContext.suppliers.SingleOrDefault(su=>su.supplierCode==erpitem.supplierCode);
 if (sup == null)
 
 sup = new supplier supplierCode = erpitem.supplierCode, name = erpitem.supplierName ;
 
 tempItem.supplier = sup;
 if (newflag)
 _appDbContext.items.AddAsync(tempItem);
 );
 if (_appDbContext.ChangeTracker.HasChanges())
 await _appDbContext.SaveChangesAsync();

This runs very slow, and sometimes even hangs (?)
(due to the supplier)
I can extract the suppliers from the incoming list and add them before looping over the list of items , hence the supplier code will always exist in the db.
I'm just not sure if thats the proper way to do it (?)
most of the online examples tackle updating/inserting a single item.

Any insight / help is much appreciated.

c# ef-core-2.2

share|improve this question

asked Mar 25 at 7:52

Nadav CaridiNadav Caridi

814

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Why it hangs requires more investigations...but for the slowly there is no silver bullet. All ORMs are powerfull in many scenario, but not in "bulk" operation: if you have to insert/update a group of hundreds entities, you have two way to do this. The first is what you did, and you have to wait. The second is "don't use orm". Write your business operation method with a sql statement with high performance to be fast.
  
  – Lorenzo Isidori
  Mar 25 at 8:05
  
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  thanks for the comment , I'm rather new to EF and I was under the impression that I'm doing something wrong if it takes such a long time.
  
  – Nadav Caridi
  Mar 25 at 8:58
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Check which lines of codes require more exeucution time...I bet is the _appDbContext.SaveChangesAsync(); who takes all the time
  
  – Lorenzo Isidori
  Mar 25 at 9:11
  
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  actually like I wrote if I comment these lines var sup = _appDbContext.suppliers.SingleOrDefault(su=>su.supplierCode==erpitem.supplierCode); if (sup == null) sup = new supplier supplierCode = erpitem.supplierCode, name = erpitem.supplierName ; tempItem.supplier = sup; it works really fast. it's due to the child entitty
  
  – Nadav Caridi
  Mar 25 at 10:00
  
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Of course, if you remove many entities he does its work fast
  
  – Lorenzo Isidori
  Mar 25 at 10:58
  

  
  
  
  

add a comment | 

0

I'm building a .net core 2 api with EF core .
the api gets a list (3K-5K) of entities(DTOs) to sync using a general syncItems function.

assume the following entities :

 public class supplier

 [Key]
 public string supplierCode get; set; 

 public string name get; set; 


 public class item 

 public const int maxItemName = 256;
 public const int maxItemCode = 256;
 public const int maxBarcode = 256;
 [Required]
 [StringLength(maxItemName)]
 public string itemName get; set; 

 [Required]
 [StringLength(maxItemCode)]
 [Key]
 public string sku get; set; 

 public supplier supplier get; set; 


 public ICollection<itemWarehouse> whslines = new List<itemWarehouse>();

 public item()
 

 



my sync does the following : 

var itemsInApp=_appDbContext.items.ToList();
 // insert or update items.
 items.ForEach(erpitem =>
 
 bool newflag = false;
 item tempItem = itemsInApp.Where(x => x.sku == erpitem.sku).FirstOrDefault();
 if (tempItem==null) // check if item is null
 
 tempItem = new item();
 tempItem.sku = erpitem.sku;
 newflag = true;
 
 tempItem.itemName = erpitem.itemName;
 var sup = _appDbContext.suppliers.SingleOrDefault(su=>su.supplierCode==erpitem.supplierCode);
 if (sup == null)
 
 sup = new supplier supplierCode = erpitem.supplierCode, name = erpitem.supplierName ;
 
 tempItem.supplier = sup;
 if (newflag)
 _appDbContext.items.AddAsync(tempItem);
 );
 if (_appDbContext.ChangeTracker.HasChanges())
 await _appDbContext.SaveChangesAsync();

This runs very slow, and sometimes even hangs (?)
(due to the supplier)
I can extract the suppliers from the incoming list and add them before looping over the list of items , hence the supplier code will always exist in the db.
I'm just not sure if thats the proper way to do it (?)
most of the online examples tackle updating/inserting a single item.

Any insight / help is much appreciated.

c# ef-core-2.2

share|improve this question

asked Mar 25 at 7:52

Nadav CaridiNadav Caridi

814

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Why it hangs requires more investigations...but for the slowly there is no silver bullet. All ORMs are powerfull in many scenario, but not in "bulk" operation: if you have to insert/update a group of hundreds entities, you have two way to do this. The first is what you did, and you have to wait. The second is "don't use orm". Write your business operation method with a sql statement with high performance to be fast.
  
  – Lorenzo Isidori
  Mar 25 at 8:05
  
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  thanks for the comment , I'm rather new to EF and I was under the impression that I'm doing something wrong if it takes such a long time.
  
  – Nadav Caridi
  Mar 25 at 8:58
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Check which lines of codes require more exeucution time...I bet is the _appDbContext.SaveChangesAsync(); who takes all the time
  
  – Lorenzo Isidori
  Mar 25 at 9:11
  
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  actually like I wrote if I comment these lines var sup = _appDbContext.suppliers.SingleOrDefault(su=>su.supplierCode==erpitem.supplierCode); if (sup == null) sup = new supplier supplierCode = erpitem.supplierCode, name = erpitem.supplierName ; tempItem.supplier = sup; it works really fast. it's due to the child entitty
  
  – Nadav Caridi
  Mar 25 at 10:00
  
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Of course, if you remove many entities he does its work fast
  
  – Lorenzo Isidori
  Mar 25 at 10:58
  

  
  
  
  

add a comment | 

I'm building a .net core 2 api with EF core .
the api gets a list (3K-5K) of entities(DTOs) to sync using a general syncItems function.

assume the following entities :

 public class supplier

 [Key]
 public string supplierCode get; set; 

 public string name get; set; 


 public class item 

 public const int maxItemName = 256;
 public const int maxItemCode = 256;
 public const int maxBarcode = 256;
 [Required]
 [StringLength(maxItemName)]
 public string itemName get; set; 

 [Required]
 [StringLength(maxItemCode)]
 [Key]
 public string sku get; set; 

 public supplier supplier get; set; 


 public ICollection<itemWarehouse> whslines = new List<itemWarehouse>();

 public item()
 

 



my sync does the following : 

var itemsInApp=_appDbContext.items.ToList();
 // insert or update items.
 items.ForEach(erpitem =>
 
 bool newflag = false;
 item tempItem = itemsInApp.Where(x => x.sku == erpitem.sku).FirstOrDefault();
 if (tempItem==null) // check if item is null
 
 tempItem = new item();
 tempItem.sku = erpitem.sku;
 newflag = true;
 
 tempItem.itemName = erpitem.itemName;
 var sup = _appDbContext.suppliers.SingleOrDefault(su=>su.supplierCode==erpitem.supplierCode);
 if (sup == null)
 
 sup = new supplier supplierCode = erpitem.supplierCode, name = erpitem.supplierName ;
 
 tempItem.supplier = sup;
 if (newflag)
 _appDbContext.items.AddAsync(tempItem);
 );
 if (_appDbContext.ChangeTracker.HasChanges())
 await _appDbContext.SaveChangesAsync();

This runs very slow, and sometimes even hangs (?)
(due to the supplier)
I can extract the suppliers from the incoming list and add them before looping over the list of items , hence the supplier code will always exist in the db.
I'm just not sure if thats the proper way to do it (?)
most of the online examples tackle updating/inserting a single item.

Any insight / help is much appreciated.

c# ef-core-2.2

share|improve this question

asked Mar 25 at 7:52

Nadav CaridiNadav Caridi

814

 public class supplier

 [Key]
 public string supplierCode get; set; 

 public string name get; set; 


 public class item 

 public const int maxItemName = 256;
 public const int maxItemCode = 256;
 public const int maxBarcode = 256;
 [Required]
 [StringLength(maxItemName)]
 public string itemName get; set; 

 [Required]
 [StringLength(maxItemCode)]
 [Key]
 public string sku get; set; 

 public supplier supplier get; set; 


 public ICollection<itemWarehouse> whslines = new List<itemWarehouse>();

 public item()
 

 



my sync does the following : 

var itemsInApp=_appDbContext.items.ToList();
 // insert or update items.
 items.ForEach(erpitem =>
 
 bool newflag = false;
 item tempItem = itemsInApp.Where(x => x.sku == erpitem.sku).FirstOrDefault();
 if (tempItem==null) // check if item is null
 
 tempItem = new item();
 tempItem.sku = erpitem.sku;
 newflag = true;
 
 tempItem.itemName = erpitem.itemName;
 var sup = _appDbContext.suppliers.SingleOrDefault(su=>su.supplierCode==erpitem.supplierCode);
 if (sup == null)
 
 sup = new supplier supplierCode = erpitem.supplierCode, name = erpitem.supplierName ;
 
 tempItem.supplier = sup;
 if (newflag)
 _appDbContext.items.AddAsync(tempItem);
 );
 if (_appDbContext.ChangeTracker.HasChanges())
 await _appDbContext.SaveChangesAsync();

share|improve this question

asked Mar 25 at 7:52

Nadav CaridiNadav Caridi

814

share|improve this question

asked Mar 25 at 7:52

Nadav CaridiNadav Caridi

814

asked Mar 25 at 7:52

Nadav CaridiNadav Caridi

814

asked Mar 25 at 7:52

Nadav CaridiNadav Caridi

814