Styjun

Im getting homework done but i faced this problem i tried everything changing variables name, changing function ....
is the problem because of the labels ?

#include<stdio.h>
#include<iostream>

struct empl 
 char nom;
 char pre;
 float salaire;
 double cin;
empl;
struct empl t[50];
struct empl E;

int taille(int n)

 printf("saisie la taille de tableauxn");
 scanf("%dn", &n);
 return 0;


int remplire(int n, struct empl t, int i)


 for (i = 1; i <= n; i++)
 
 printf("t[%d].nom= ", i);
 scanf("%sn", &t[i].nom);
 printf("t[%d].prenom= ", i);
 scanf("%sn", &t[i].pre);
 printf("t[%d].salaire= ", i);
 scanf("%fn", &t[i].salaire);
 printf("t[%d].CIN= ", i);
 scanf("%lfn", &t[i].cin);
 

int main()

 int i, n;
 int taille(int n),
 taille(n);
 int remplire(int n, struct empl t, int i);
 remplire(n, t, i);

Although your code is written mostly in C style, you seem to be compiling it with a C++ compiler, as it accepts #include <iostream> (though you do not appear to use anything from it), and it has a notion of operator overloading. C and C++ are distinct languages, and the distinction is somewhat relevant here.

In either language, however, the code you have presented is flawed. The problem is with the several expressions in function remplire that follow this pattern: &t[i].nom. Absent any operator overloading (which is not available in C anyway), the [] operator in those expressions requires one of its operands to designate either a pointer or an array, and the other to designate an integer. Although there is a file-scope variable t that is an array, inside remplire() that is shadowed by a function parameter with the same name. Inside that function, then, t refers the the parameter, which is a struct empl, not an array or pointer (or integer).

Your compiler ought to be giving you another clue, too, where you call that function ...

 remplire(n,t,i);

..., passing the global t as an argument. The compiler very much should complain about a type mismatch between the second argument (t) and the corresponding function parameter.

Perhaps what you wanted to do is simply to declare remplire() to accept a structure pointer as its second parameter:

int remplire(int n, struct empl *t, int i)

While you're at it, do remove the redundant local declaration of that function inside main(). You don't need that as long as remplire() is defined before main(), and if you want to have a separate declaration of that function then it would best be placed at file scope, and probably in a header file.

First of all iostream is C++ header coming from standard library and will not work for C program. And now issues:

int taille (int n)

 printf("saisie la taille de tableauxn");
 scanf("%dn",&n);
 return 0;

This function is called with an input parameter - that means you can pass a value into a function, but not access the parameter and hope it will be used in other places. To correct this you should declare the function should look like this:

int taille (int * n)

 printf("saisie la taille de tableauxn");
 scanf("%dn", n);
 return 0;

Next function - similar problem, it should look like this:

int remplire (int n , struct empl * t ,int i)

 for (i=1;i<=n;i++)
 
 printf("t[%d].nom= ",i);
 scanf("%sn",&t[i].nom);
 printf("t[%d].prenom= ",i);
 scanf("%sn",&t[i].pre);
 printf("t[%d].salaire= ",i);
 scanf("%fn",&t[i].salaire);
 printf("t[%d].CIN= ",i);
 scanf("%lfn",&t[i].cin);
 

Or even like this:

int remplire (int n , int i)

as t is global variable. Also this function should return some value as it is declared to return int.

And now the main function:

int main()
 
 int i,n;
 int taille(int n),
 taille(n);
 int remplire(int n,struct empl t,int i);
 remplire(n,t,i);

Don't redeclare functions inside another function, even if it is permissible it does not mean you should do it. Also main function should return 0 if everything works fine. To correct the function write it like this:

int main()
 
 int i,n;
 taille(& n);
 remplire(n,& t,i);

Some good advice, please read some books to learn how to program in C if you want to go that way.

There are many issues in your code.

Starting reading a good C textbook is advised.

You probably want this:

#include <stdio.h>
#include <iostream>

struct empl 
 char nom[30];
 char pre[30];
 float salaire;
 double cin;
empl;

struct empl t[50];
struct empl E;

int taille(int & n)

 printf("saisie la taille de tableauxn");
 scanf("%d", &n);
 return 0;


void remplire(int n, struct empl *t)

 for (int i = 0; i < n; i++)
 
 printf("t[%d].nom= ", i);
 scanf("%s", &t[i].nom);
 printf("t[%d].prenom= ", i);
 scanf("%s", &t[i].pre);
 printf("t[%d].salaire= ", i);
 scanf("%f", &t[i].salaire);
 printf("t[%d].CIN= ", i);
 scanf("%lf", &t[i].cin);
 


int main()

 int n;
 taille(n);
 remplire(n, t);

It's still poor code and it's written mostly in C style, but it compiles and works as intended.

In C++ you'd do this totally differently.

You've declared this global array variable t

struct empl t[50];

and also declared a parameter t in this function

int remplire (int n , struct empl t ,int i)

Inside the function it's going to treat any instance of t as to be the parameter as that is nearer in scope than the global variable. So when you have code like this...

scanf("%sn",&t[i].nom);

...it's going to throw up errors because t isn't an array.

The solution is to use variable names that have meaning like "employee_array" rather than single letters.

Also that call to scanf is wrong as for strings you don't need to pass in a pointer to the variable, so it should look like

scanf("%sn",t[i].nom);

But you'd also need to make nom be a string too - currently it's only a char.